Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version match documentation #2266

Open
wants to merge 1 commit into
base: 3.x
Choose a base branch
from

Conversation

kjkooistra-youwe
Copy link

Matching version argument does not work, as it's null.
Use requirements instead.

Also see symfony/symfony#38034

Matching version argument does not work, as it's null.
Use requirements instead.
@xabbuh
Copy link
Member

xabbuh commented Sep 2, 2020

I think we should have both examples. If the version is not derived from the path, you will still need to use the condition option. You can take a look at the Version2Controller class in the tests which contains examples for both.

@kjkooistra-youwe
Copy link
Author

Hmm, but won't that require a more structural update? How will that work with multiple options enabled, for instance? https://symfony.com/doc/3.x/bundles/FOSRestBundle/versioning.html#how-to-version-your-api

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants